Update parsing to work with the more generic project-felt markdown repo by jschuler · Pull Request #232 · patternfly/patternfly-doc-core

jschuler · 2026-05-01T15:46:47Z

Found here
https://github.com/project-felt/ai-guidelines

in patternfly-org pf-docs.config.mjs

{
    base: "../../node_modules/@redhat/ai-guidelines",
    pattern: "content/*.md",
    name: "ai-guidelines",
    frontmatterDefaults: { section: "AI", subsection: "Guidelines" },
    frontmatterMapping: { title: "id" },
}

Summary by CodeRabbit

New Features
- Navigation now supports subsections with hierarchical grouping and nested display.
- Content collections support configurable frontmatter defaults and field mapping for flexible metadata handling.
Improvements
- URL paths now use consistent kebab-case formatting for dynamic routes.
- CLI robustness improved for package resolution failures.

coderabbitai · 2026-05-01T15:47:00Z

Warning

Rate limit exceeded

@jschuler has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 21 minutes and 15 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 13e6a5f2-66e3-4901-8831-73ff81013343

📥 Commits

Reviewing files that changed from the base of the PR and between a405709 and c773609.

📒 Files selected for processing (3)

cli/cli.ts
src/pages/[section]/[...page].astro
src/pages/[section]/[page]/[tab].astro

Walkthrough

This PR introduces subsection grouping for navigation entries, adds configurable frontmatter defaults and mappings to the content schema, normalizes section route parameters to kebab-case, and improves CLI error handling by resolving astroRoot relative to the CLI file location.

Changes

Cohort / File(s)	Summary
CLI Updates `cli/cli.ts`, `cli/getConfig.ts`	Improved astroRoot resolution logic when module resolution fails; added `frontmatterDefaults` and `frontmatterMapping` optional properties to `CollectionDefinition` interface to support configurable frontmatter handling.
Navigation Subsectioning `src/components/NavEntry.tsx`, `src/components/NavSection.tsx`, `src/components/Navigation.astro`	Extended `TextContentEntry` interface with optional `subsection` property; modified `NavSection` to partition entries into top-level items and subsection groups, rendering subsections as nested expandable sections; updated `Navigation.astro` to propagate subsection data downstream.
Content Schema Configuration `src/content.config.ts`	Generalized content collection schema to support configurable frontmatter via `frontmatterDefaults` and `frontmatterMapping`; added conditional optionality for `id` and `section` fields; introduced post-processing transform for field mapping and default value application; added support for additional frontmatter fields like `category`, `subcategory`, `description`, and `tags`.
Route Normalization `src/pages/[section]/[...page].astro`, `src/pages/[section]/[page]/[tab].astro`	Applied kebab-case normalization to the `section` route parameter in static path generation to ensure consistency between generated routes and URL comparisons.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested reviewers

dlabaj

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly describes the primary change: updating parsing to work with a more generic markdown repository structure, which aligns with the core changes across content configuration, navigation, and schema handling.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 0/1 reviews remaining, refill in 21 minutes and 15 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 3

🧹 Nitpick comments (1)

src/components/NavSection.tsx (1)
19-66: 💤 Low value

Well-structured subsection grouping implementation.

The logic correctly partitions entries and renders nested NavExpandable components. The extracted renderEntry helper improves maintainability.

Minor consideration: at line 61, the id attribute uses the raw subsection string. If subsection names contain spaces or special characters (e.g., "AI Guidelines"), the DOM id may be invalid. Consider using kebabCase(subsection) for consistency:
-            id={`nav-subsection-${sectionId}-${subsection}`}
+            id={`nav-subsection-${kebabCase(sectionId)}-${kebabCase(subsection)}`}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/NavSection.tsx` around lines 19 - 66, The DOM id for
subsection NavExpandable uses the raw subsection string which can produce
invalid ids for names with spaces or special chars; in the NavSection component
update the id (and optionally the React key) for the subsection NavExpandable
from `nav-subsection-${sectionId}-${subsection}` to use `kebabCase(subsection)`
(e.g., `nav-subsection-${sectionId}-${kebabCase(subsection)}`) so ids are
normalized and consistent with the other kebabCase usage in renderEntry/active
checks.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@cli/cli.ts`:
- Around line 40-41: The build fails because dirname is used but not imported;
update the import that provides fileURLToPath to also import dirname so
dirname(fileURLToPath(import.meta.url)) works correctly when computing cliDir
and resolving astroRoot (look for the import that currently brings in
fileURLToPath and add dirname to it), then re-run typecheck to ensure cliDir and
astroRoot assignments compile.

In `@src/pages/`[section]/[...page].astro:
- Line 60: The rewrite is using the raw section value (entry.data.section) while
route params use kebabCase(entry.data.section), causing mismatched URLs; update
the Astro.rewrite call to use the same kebab-cased section (e.g.,
kebabCase(entry.data.section) or a precomputed const like const sectionSlug =
kebabCase(entry.data.section)) so both params and Astro.rewrite reference the
identical normalized section value (also ensure any other uses of
entry.data.section in this file use the slug variable).

In `@src/pages/`[section]/[page]/[tab].astro:
- Line 67: The template builds URLs using the raw entry.data.section, which can
mismatch the kebab-cased route param set earlier
(kebabCase(entry.data.section)); update the URL constructions that reference
entry.data.section (the links around where you render the page/tab URLs) to use
the kebab-cased value instead — either call kebabCase(entry.data.section) inline
or use the already-normalized section value (kebabCase(entry.data.section))
produced earlier so generated links match the static paths.

---

Nitpick comments:
In `@src/components/NavSection.tsx`:
- Around line 19-66: The DOM id for subsection NavExpandable uses the raw
subsection string which can produce invalid ids for names with spaces or special
chars; in the NavSection component update the id (and optionally the React key)
for the subsection NavExpandable from
`nav-subsection-${sectionId}-${subsection}` to use `kebabCase(subsection)`
(e.g., `nav-subsection-${sectionId}-${kebabCase(subsection)}`) so ids are
normalized and consistent with the other kebabCase usage in renderEntry/active
checks.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 762f1cee-d9cf-4cd5-944b-b05b1804c56d

📥 Commits

Reviewing files that changed from the base of the PR and between 10aeffc and a405709.

📒 Files selected for processing (8)

cli/cli.ts
cli/getConfig.ts
src/components/NavEntry.tsx
src/components/NavSection.tsx
src/components/Navigation.astro
src/content.config.ts
src/pages/[section]/[...page].astro
src/pages/[section]/[page]/[tab].astro

wise-king-sullyman · 2026-05-05T20:39:18Z

+      ])
+      .optional(),
+  }).transform((data) => {
+    const result: Record<string, unknown> = { ...data }


I'm wondering if this Record<string, unknown> typing on this transform is going to cause issues?

It’s only for TS's view of the data after applying config-based mapping/defaults
runtime behavior and validation should be unchanged

Update parsing to work with the more generic project-felt markdown repo

a405709

dirname

018579f

coderabbitai Bot reviewed May 1, 2026

View reviewed changes

Comment thread cli/cli.ts

Comment thread src/pages/[section]/[...page].astro

Comment thread src/pages/[section]/[page]/[tab].astro

coderabbit

c773609

wise-king-sullyman reviewed May 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update parsing to work with the more generic project-felt markdown repo#232

Update parsing to work with the more generic project-felt markdown repo#232
jschuler wants to merge 3 commits intopatternfly:mainfrom
jschuler:project-felt

jschuler commented May 1, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 1, 2026 •

edited

Loading

Rate limit exceeded

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wise-king-sullyman May 5, 2026

Uh oh!

jschuler May 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

jschuler commented May 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Suggested reviewers

❌ Failed checks (1 warning)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wise-king-sullyman May 5, 2026

Choose a reason for hiding this comment

Uh oh!

jschuler May 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

jschuler commented May 1, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 1, 2026 •

edited

Loading